containers: fix swap for PiercedStorage<bool> #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardolombardi
approved these changes
Jun 27, 2022
andrea-iob
force-pushed
the
containers.fix.bool.swap
branch
from
1e2e2ed
to
f94fe30
Compare
The [] operator of std::vector<bool> returns a temporary object of a proxy type called std::vector<bool>::reference, rather than an actual bool&. Although the libstdc++ defines an overload for swapping this type of proxy objects, this is just an extension to the standard.
andrea-iob
force-pushed
the
containers.fix.bool.swap
branch
from
f94fe30
to
fceab08
Compare
|
I've added a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The [] operator of std::vector returns a temporary object of a proxy type called std::vector::reference, rather than an actual bool&.
Although the libstdc++ defines an overload for swapping this type of proxy objects, this is just an extension to the standard.
Without this change bitpit doesn't compile with gcc 12.